Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1624): fix unbound variable in resync cardano node workflow #1625

Merged

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • Fix the following error:
sed -e "s|<DBSYNC_POSTGRES_DB>|${DBSYNC_POSTGRES_DB}|" \
	-e "s|<DBSYNC_POSTGRES_USER>|${DBSYNC_POSTGRES_USER}|" \
	-e "s|<DBSYNC_POSTGRES_PASSWORD>|${DBSYNC_POSTGRES_PASSWORD}|" \
	-e "s|<DBSYNC_POSTGRES_HOST>|${DBSYNC_POSTGRES_HOST}|" \
	-e "s|<DBSYNC_POSTGRES_PORT>|${DBSYNC_POSTGRES_PORT}|" \
	-e "s|<SENTRY_DSN>|${SENTRY_DSN_BACKEND}|" \
	-e "s|<SENTRY_ENV>|test|" \
	/home/runner/work/govtool/govtool/scripts/govtool/config/templates/backend-config.json.tpl > /home/runner/work/govtool/govtool/scripts/govtool/config/target/backend-config.json
bash: line 1: DBSYNC_POSTGRES_HOST: unbound variable
make: *** [config.mk:85: /home/runner/work/govtool/govtool/scripts/govtool/config/target/backend-config.json] Error 1

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jul 30, 2024 that may be closed by this pull request
@MSzalowski MSzalowski mentioned this pull request Jul 30, 2024
Copy link
Contributor

@placek placek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a hotfix that will work just fine.

I'm wondering wether we should review that to verify which services actualy use those ENVs

@MSzalowski
Copy link
Contributor Author

As a hotfix that will work just fine.

I'm wondering wether we should review that to verify which services actualy use those ENVs

We are not using those ENVs so far, I've made just a placeholder for the potential usage under deployment via github actions

@MSzalowski MSzalowski merged commit defeb51 into develop Jul 30, 2024
@MSzalowski MSzalowski deleted the fix/1624-unbound-variable-affects-resync-workflow branch July 30, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unbound variable affects resync workflow
2 participants