Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1623): Move querying metadata-validation to frontend service #1649

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Jul 31, 2024

Summary

Haskell backend should be responsible only for fetching the DB-sync data. So I moved the querying the metadata-service logic to frontend that can consume 2 backends with ease and later on - react on socket events when appropriate designs on the cards are done.
That operation helps in decreasing the complexity level in Haskell backend making it easier to track and investigate errors around faulty SQL (#ref) or Thread killed by timeout issues - #1417

List of changes

  • Move metadata-validation service requests to frontend service

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jul 31, 2024 that may be closed by this pull request
@MSzalowski
Copy link
Contributor Author

After much time on investigation this issue I decided to not include fix for that in that PR and provide metadata from validation service once validated.

@MSzalowski MSzalowski force-pushed the fix/1623-call-to-metadata-validation-service-fails-from-haskell-backend branch from 6c18c9f to 95f2167 Compare August 1, 2024 08:11
@MSzalowski MSzalowski marked this pull request as ready for review August 1, 2024 08:11
@MSzalowski MSzalowski changed the title Fix/1623 call to metadata validation service fails from haskell backend fix(#1623): Move querying metadata-validation to frontend service Aug 1, 2024
@MSzalowski
Copy link
Contributor Author

This PR is the solution candidate as it introduces breaking change to the infrastructure.
I'll make more investigation around #1650 before merging this one.

Copy link
Contributor

@placek placek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSzalowski MSzalowski requested a review from jdyczka August 1, 2024 13:49
@MSzalowski MSzalowski merged commit a7101aa into develop Aug 1, 2024
6 checks passed
@MSzalowski MSzalowski deleted the fix/1623-call-to-metadata-validation-service-fails-from-haskell-backend branch August 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to metadata validation service fails from Haskell backend
3 participants