-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#1623): Move querying metadata-validation to frontend service #1649
fix(#1623): Move querying metadata-validation to frontend service #1649
Conversation
After much time on investigation this issue I decided to not include fix for that in that PR and provide metadata from validation service once validated. |
6c18c9f
to
95f2167
Compare
This PR is the solution candidate as it introduces breaking change to the infrastructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Haskell backend should be responsible only for fetching the DB-sync data. So I moved the querying the metadata-service logic to frontend that can consume 2 backends with ease and later on - react on socket events when appropriate designs on the cards are done.
That operation helps in decreasing the complexity level in Haskell backend making it easier to track and investigate errors around faulty SQL (#ref) or
Thread killed by timeout issues
- #1417List of changes
Checklist