Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2062] change CC vote totals labels #2078

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[#2062] change CC vote totals labels #2078

merged 1 commit into from
Sep 26, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Sep 25, 2024

List of changes

  • Change constitutional committee vote totals to be constitutional for yes and unconstitutional for no

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka requested a review from placek September 25, 2024 09:12
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@jdyczka jdyczka merged commit fb2eda6 into develop Sep 26, 2024
8 checks passed
@jdyczka jdyczka deleted the feat/2062-cc-vote-totals branch September 26, 2024 09:31
@github-actions GitHub Actions
Copy link

@jdyczka
This PR is in the tag: develop-fb2eda64f72e362aa15e74a29136836e305e9682 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@jdyczka
This PR is in the tag: develop-fb2eda64f72e362aa15e74a29136836e305e9682 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@jdyczka
This PR is in the tag: develop-fb2eda64f72e362aa15e74a29136836e305e9682 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdyczka @placek @j-dyczka