Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test deployment: Fail if any service crash when updating #2088

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Test deployment: Fail if any service crash when updating #2088

merged 3 commits into from
Sep 27, 2024

Conversation

mesudip
Copy link
Contributor

@mesudip mesudip commented Sep 27, 2024

List of changes

  • Update github ssh script to add fail on any error.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

4 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

kneerose
kneerose approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@kneerose kneerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@mesudip mesudip merged commit b5384e5 into develop Sep 27, 2024
4 checks passed
@mesudip mesudip deleted the infra/test-chores branch September 27, 2024 08:48
@github-actions GitHub Actions
Copy link

@mesudip
This PR is in the tag: develop-b5384e5e48fc336c7923e0a38709315e7d19df96 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneerose kneerose kneerose approved these changes

@placek placek Awaiting requested review from placek placek is a code owner

@adgud adgud Awaiting requested review from adgud adgud is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesudip @kneerose