Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: no DRep found copy text #2202

Merged
merged 4 commits into from
Oct 28, 2024
Merged

change: no DRep found copy text #2202

merged 4 commits into from
Oct 28, 2024

Conversation

Ryun1
Copy link
Member

@Ryun1 Ryun1 commented Oct 23, 2024

List of changes

  • Change copy for no DRep found via directory

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

5 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski
Copy link
Contributor

Should similar go to the governance actions page?

@bosko-m
Copy link
Contributor

bosko-m commented Oct 23, 2024

What would you make it say on GA page @MSzalowski ?

MSzalowski
MSzalowski approved these changes Oct 24, 2024
View reviewed changes
govtool/frontend/src/i18n/locales/en.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski merged commit a5e7dbd into develop Oct 28, 2024
8 checks passed
@MSzalowski MSzalowski deleted the drep-search-copy branch October 28, 2024 10:58
@github-actions GitHub Actions
Copy link

@Ryun1
This PR is in the tag: develop-a5e7dbd03ab257d0dde7b4e673157fb8462849ee , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@Ryun1
This PR is in the tag: develop-a5e7dbd03ab257d0dde7b4e673157fb8462849ee , for govtool-metadata-validation service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosko-m bosko-m bosko-m approved these changes

@jdyczka jdyczka jdyczka left review comments

@MSzalowski MSzalowski MSzalowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ryun1 @MSzalowski @bosko-m @jdyczka