Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1893): add searching for metadatas in DRep and Proposal lists #2216

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix(#1893): add searching for metadatas in DRep and Proposal lists #2216

merged 3 commits into from
Oct 28, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • add search for metadatas in the DRep list
  • add search for metadatas in the Proposal list

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Oct 24, 2024 that may be closed by this pull request
🐛 DRep search only works for DRep IDs #1893
Closed
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

5 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1893-drep-search-only-works-for-drep-ids branch from 742d13d to 894a05a Compare October 24, 2024 09:54
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1893-drep-search-only-works-for-drep-ids branch from 894a05a to 44e1ba2 Compare October 28, 2024 09:01
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1893-drep-search-only-works-for-drep-ids branch from 44e1ba2 to baf3595 Compare October 28, 2024 10:23
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1893-drep-search-only-works-for-drep-ids branch from baf3595 to 69267e7 Compare October 28, 2024 10:33
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski merged commit cfe4e91 into develop Oct 28, 2024
10 checks passed
@MSzalowski MSzalowski deleted the fix/1893-drep-search-only-works-for-drep-ids branch October 28, 2024 10:47
@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-cfe4e9109b859508a564a1dffdb64ddacf3adf6c , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-cfe4e9109b859508a564a1dffdb64ddacf3adf6c , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-cfe4e9109b859508a564a1dffdb64ddacf3adf6c , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdyczka jdyczka jdyczka approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 DRep search only works for DRep IDs
2 participants
@MSzalowski @jdyczka