Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for vote context anchor validation #2239

Merged
merged 3 commits into from
Oct 28, 2024
Merged

test for vote context anchor validation #2239

merged 3 commits into from
Oct 28, 2024

Conversation

kneerose
Copy link
Contributor

List of changes

  • Update test id of vote context metadata anchor URL and metadata download
  • Add test 4N Should accept valid metadata anchor on vote context
  • Add test 4O Should reject invalid metadata anchor on vote context

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip October 28, 2024 10:05
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

mesudip
mesudip approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@kneerose kneerose merged commit 597876d into develop Oct 28, 2024
3 checks passed
@kneerose kneerose deleted the tests/vote-context-anchor-validation branch October 28, 2024 10:30
@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-597876d686b4319b38c091c9a59b776583a76ccb , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-597876d686b4319b38c091c9a59b776583a76ccb , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-597876d686b4319b38c091c9a59b776583a76ccb , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip