Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/support space on dRep name #2339

Merged
merged 2 commits into from
Nov 6, 2024
Merged

tests/support space on dRep name #2339

merged 2 commits into from
Nov 6, 2024

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Nov 6, 2024

List of changes

  • Update dRep for data validation test to support dRep name with space

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip November 6, 2024 10:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

✅ All checks succeeded

mesudip
mesudip approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@kneerose kneerose merged commit b47c775 into develop Nov 6, 2024
4 checks passed
@kneerose kneerose deleted the tests/support-space-on-dRep-name branch November 6, 2024 14:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

@kneerose
This PR is in the tag: develop-b47c775ea667cfbe1a9b4e36729668815808b292 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

@kneerose
This PR is in the tag: develop-b47c775ea667cfbe1a9b4e36729668815808b292 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

@kneerose
This PR is in the tag: develop-b47c775ea667cfbe1a9b4e36729668815808b292 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip