Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2276): add support for space in given name #2343

Merged
merged 1 commit into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ changes.

- Change multilanguage support to use json file [Issue 2325](https://github.com/IntersectMBO/govtool/issues/2325)
- Display full Governance Action IDs on desktop
- Support space on given name [Issue 2276](https://github.com/IntersectMBO/govtool/issues/2276)

### Removed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const EditDRepStorageInformation = ({
} = useEditDRepInfoForm(setStep);
const { screenWidth } = useScreenDimension();

const fileName = getValues("givenName").replace(/\s/g, "");
const fileName = getValues("givenName");
const openGuideAboutStoringInformation = () =>
openInNewTab(
"https://docs.gov.tools/using-govtool/govtool-functions/storing-information-offline",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const DRepStorageInformation = ({
} = useRegisterAsdRepForm(setStep);
const { screenWidth } = useScreenDimension();

const fileName = getValues("givenName").replace(/\s/g, "");
const fileName = getValues("givenName");

const openGuideAboutStoringInformation = () =>
openInNewTab(
Expand Down
4 changes: 0 additions & 4 deletions govtool/frontend/src/consts/dRepActions/fields.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ export const Rules = {
maxLength: 80,
}),
},
pattern: {
value: /^[^\s]+$/,
message: i18n.t("registration.fields.validations.noSpaces"),
},
},
LINK_DESCRIPTION: {
maxLength: {
Expand Down
Loading