[#466] Enhancing Docker Compose stack for proper frontend image tagging #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure frontend image builds can distinguish between different environments, an additional distinction based on the environment tag has been introduced. This change was necessary as the commit altering the frontend module alone was insufficient. By adding an environment tag to the image tag name, applications with the same version can now be uniquely identified across various environments. Changes Made: - Modified the Makefile in the govtool/frontend directory to introduce an environment tag to the image tag name used in frontend image builds. The new tag is generated by appending the environment variable to the commit hash obtained from the git log command, ensuring each build is uniquely identified per environment.
placek
requested review from
MSzalowski,
Sworzen1,
JanJaroszczak and
kickloop
as code owners
4 tasks
MSzalowski
approved these changes
Mar 13, 2024
placek
deleted the
hotfix/466-enhancing-docker-compose-stack-for-proper-frontend-image-tagging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #466.
Purpose of the Changes:
The purpose of these changes is to fix the Docker Compose stack in order to
properly tag frontend images with environment-specific flags. This improvement
aims to address the issue where frontend images generated based on the last
commit SHA were inadequate due to variations in build arguments and deployment
settings across different environments. By introducing an environment flag to
the image tag, the goal is to ensure that the correct frontend build is utilized
for each specific deployment environment.
Outcome of the Changes:
The introduced modification includes updating the Makefile in the
govtool/frontend directory to incorporate an environment tag to the image tag
name used during frontend image builds. This new tag generation process merges
the environment variable with the commit hash retrieved from the git log
command, guaranteeing a unique identification for each build based on the
environment. Consequently, applications sharing the same version can now be
distinctly recognized across diverse deployment environments, improving
deployment accuracy and environment segregation.