Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[59] Fixed vote counting problem #74

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Jan 23, 2024

Votes were counted in a wrong way, especially when it came to NoConfidence GAs and AlwaysNoConfidence DRep. The SQL query was modified and the problem is fixed

List of changes

  • Fixed
    Fixed vote calculation problems regarding NoConfidence GAs and DRep

Checklist

  • related issue
  • [] My changes generate no new warnings
  • [] My code follows the style guidelines of this project
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the changelog
  • [] I have added tests that prove my fix is effective or that my feature works

@jankun4 jankun4 linked an issue Jan 23, 2024 that may be closed by this pull request
@Ryun1
Copy link
Member

Ryun1 commented Jan 23, 2024

Please fill in the PR template @jankun4

@jankun4
Copy link
Contributor Author

jankun4 commented Jan 24, 2024

Which PR template exactly? @Ryun1

Votes were counted in a wrong way, especially when it came to NoConfidence GAs and AlwaysNoConfidence DRep. The SQL query was modified and the problem is fixed
@jankun4 jankun4 force-pushed the fix/59-fix-predefined-drep-voting-power branch from 0807694 to 9fcfeaf Compare January 24, 2024 09:47
@jankun4 jankun4 merged commit cfe2b2b into main Jan 24, 2024
@MSzalowski MSzalowski deleted the fix/59-fix-predefined-drep-voting-power branch June 12, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix predefined DRep voting power
3 participants