-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual fixes, AWS Registry Setup & DRep Pagination Fix: Maintenance and Testing Expansion #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jankun4 <[email protected]>
The user story described a situation where the deployment to the Dev environment was failing due to missing context for the status-service. The expected behavior was for the deploy to succeed. In response, a status-service AWS registry was created to address this missing context, ensuring that the deploy to Dev can now successfully utilize the status-service.
The user story indicated that the deployment to the dev environment was failing due to a missing context for the status-service. To address this issue and enable a successful deployment, a status-service AWS registry was created. However, to further enhance the deployment process, a metadata-validation registry has been implemented. This addition ensures that the necessary context is available for the deployment, optimizing the functionality and reliability of the Dev environment.
The user story highlighted the issue of a failed deployment to the dev environment due to a missing context for the status-service. The expected behavior was for the deploy to succeed. To address this, changes were made to incorporate the status-service docker image utilization into the deploy stack. The addition of the status-service AWS registry now ensures that the necessary context is available for the deployment process, moving the build process to the machine where the deploy is performed, allowing for a successful deployment to the dev environment.
… stack The user story highlighted the issue of a failed deployment to the dev environment due to a missing context for the status-service. The expected behavior was for the deploy to succeed. In response to this, changes have been made to integrate the metadata-validation docker image into the deploy stack. By creating the necessary context for the metadata-validation registry, the deployment process can now utilize this image efficiently. The modifications include new files like `Makefile` in `govtool/metadata-validation`, adjustments in `scripts/govtool/Makefile` to incorporate the metadata-validation registry, and changes in `docker-compose.yml.tpl` and `info.mk` to include metadata-validation details for enhanced deployment functionality.
…-the-status-service-fails-deploy-to-dev [#742] Missing context for the status service fails deploy to dev
[#826] fix drep/list sql
…d-of-the-page-content fix: fix footer alignment across pages
fix: Status modal error message overflow & DelegateDashboardCard transactionId
chore/utils-test
This adds Terraform code that creats "participation" subdomains for each environments. The exception is the beta environment, where DNS records are not handled with TF, but need to be created manually.
…rep-directory chore/add-data-test-id-in-drep-directory
[#849] Configure sanchogov.tools sub-domain for the analytics service
fix/metadata-validation
fix/loaders
chore/add-supported-links
pmbinapps
requested review from
placek,
adgud,
MSzalowski,
Sworzen1,
JanJaroszczak and
Ryun1
as code owners
April 24, 2024 15:33
MSzalowski
approved these changes
Apr 24, 2024
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
add tests - part 2
add tests - part 3
add tests - part 4
[#742] Create a status-service AWS registry
[#742] Create a metadata-validation AWS registry
[#742] Add status service docker image utilization to the deploy stack
[#742] Add metadata-validation docker image utilization to the deploy stack
[#849] Configure sanchogov.tools sub-domain for the analytics service
add test ids for drep directory
change mocked data
Fix:
fix: typo on maintenance page
[#826] fix drep/list sql
fix: fix footer alignment across pages
[#740] fix: fix type check error on useDelegateToDRepForm hook
fix: hasNextPage and fetchNextPage fix
fix: Status modal error message overflow
fix: DelegateDashboardCard transactionId fix
fix loaders
fix missing GA data
Change:
chore: update the copy text on the maintenance page
docs: update the copy on maintenance page
chore: add incorrect format error type
change mocked data
chore: add supported links