Fix building analytics image for multiple environments #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current commit modifies the script `analytics-dashboard.mk` in the `govtool` directory to address the issue of building the analytics image for multiple environments. Previously, the image tag was being generated based on the latest commit hash for the `analytics-dashboard`, which was not sufficient for distinguishing between different environments. To solve this, the script now appends the `$(env)` variable to the image tag, allowing for unique identification of images across various environments.
MSzalowski
approved these changes
May 7, 2024
placek
deleted the
fix/fix-building-analytics-image-for-multiple-environments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR modifies the script
analytics-dashboard.mkin thegovtooldirectory to address the issue of building the analytics image for multiple environments. Previously, the image tag was being generated based on the latest commit hash for theanalytics-dashboard, which was not sufficient for distinguishing between different environments. To solve this, the script now appends the$(env)variable to the image tag, allowing for unique identification of images across various environments.This addesses the CORS issue on test env.