Consolidate protocol versions in cardano-tools
#276
Assignees
Labels
enhancement
New feature or request
Comments
|
We chatted and initially think the |
|
Related to #275 |
4 tasks
|
Note that this will be superseded by #324 |
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 26, 2024
While giving us flexibility, using different protocol versions for all eras increased the level of complexity and led to several errors in the past. This PR removes this flexibility by using a single protocol version, which determines the maximum protocol version Consensus supports. See #324 for more background. Closes #324. Closes #276. TODOs: - [x] Format the code. - [x] Fix ThreadNet test failure. - [x] Improve documentation. - [x] Address all the `FIXME`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the Cardano protocol versions are defined twice in
ouroboros-consensus-cardano-tools:For db-analyser in
Cardano.Tools.DBAnalyser.Block.CardanoHere, e.g.
alonzoProtVeris correctly set to7since db-analyser: correct protocol versions ouroboros-network#4377 (note that, somewhat confusingly, this is not the Alonzo protocol version, see this comment):ouroboros-consensus/ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBAnalyser/Block/Cardano.hs
Line 329 in eddc225
For db-synthesizer in
Cardano.Node.Protocol.CardanoHere, e.g.
alonzoProtVeris incorrect:ouroboros-consensus/ouroboros-consensus-cardano-tools/src/Cardano/Node/Protocol/Cardano.hs
Line 210 in eddc225
The goal of this ticket is to correct these discrepancies by consolidating them. This can serve as the baseline to extract this into a library that can also be reused in the node here, cf. IntersectMBO/ouroboros-network#3925.
For your convenience: See this table from CIP-0059 for an overview of the different protocol versions.
The text was updated successfully, but these errors were encountered: