Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Genesis benchmarks #1209

Draft
wants to merge 76 commits into
base: main
Choose a base branch
from
Draft

[WIP] Genesis benchmarks #1209

wants to merge 76 commits into from

Conversation

nbacquey
Copy link
Contributor

@nbacquey nbacquey commented Aug 6, 2024

This PR only exists so we can have CI running on genesis/benchmarks-rebased-new

facundominguez and others added 30 commits July 23, 2024 16:54
@facundominguez
Introduce a collection of chainsync handles that synchronizes a map a…
1369102 
…nd a queue
@facundominguez
Implement a call to rotate dynamos in CSJ
e3be2f1
@facundominguez @Niols
Comment formatting
3c42b51 
Co-authored-by: Nicolas Jeannerod <[email protected]>
@Niols @facundominguez
Rename varHandles to readHandles for consistency
407db3b
@Niols @facundominguez
Mention that the objector also gets demoted
92ff252
@Niols @facundominguez
Specify the order in which to start the peers
d7d7acc
@Niols @facundominguez
Add a BlockFetch leashing attack test
705daf4
@Niols @facundominguez
Switch peer simulator to FetchModeBulkSync
8bd6815
@Niols @facundominguez
Track the last time the ChainDB thread was starved
31705f2
@Niols @facundominguez
Plug rotateDynamo into BlockFetchConsensusInterface
b20f711
@Niols @facundominguez
Change how last starvation is recorded
e894140 
Previously, we only registered the time at which starvation started.
This is in fact not enough: if after the grace period the peer is still
not making us unstarved, we won't detect it. Instead, we record the last
starvation as either ongoing or we record its end time.
@facundominguez
Revert "GSM: use diffusion layer info for HAA"
ebc49ce 
This reverts commit 4946b3b.
@Niols @facundominguez
Fix starvation detection; improve tracing
7beffdc
@Niols @facundominguez
Follow changes of tracing in peer simulator
d3dbdf8
@Niols @facundominguez
Follow configurable grace period
b0946d3
@Niols @facundominguez
Allow parameterizing whether chainsel starvation is handled
2d51933
@Niols @facundominguez
Trace the time at which starvation started
90d613c
@Niols @facundominguez
stylish haskell
50ac9b1
@Niols @facundominguez
Follow change in trace chainselstarvationstarted
60d0d62
@Niols @mrBliss @facundominguez
ChainDB: let the BlockFetch client add blocks asynchronously
1efae68 
This is a port of PR IntersectMBO/ouroboros-network#2721 to the new ChainSelQueue.

Co-authored-by: mrBliss <[email protected]>
@Niols @facundominguez
Some wiggle room for duplicate headers
91bf46d
@Niols @facundominguez
Disable chainsel starvation in CSJ test
bc445da
@facundominguez
Depend on the ouroboros-network fork with the latest blockfetch
e93b423
@facundominguez
Accomodate for the addition of ChainSyncClientHandleCollection and gr…
5e5b37d 
…ace period and starvation event in BlockFetch
@Niols @facundominguez
Follow removal of bfcMaxConcurrencyBulkSync
5aaa882
@Niols @facundominguez
Only log starvations when they actually start
7ac6a88
@Niols @facundominguez
Revert "ChainDB: let the BlockFetch client add blocks asynchronously"
956332f 
This reverts commit 09e9837.
@Niols @facundominguez
Add explicit tracing events for CSJ
e742b01
@Niols @facundominguez
Follow changes in blockfetch decision tracing
a12cd89
@nbacquey @facundominguez
Move Genesis-specific BlockFetch config to GenesisConfig
eafa6a4
facundominguez and others added 25 commits July 30, 2024 19:57
@facundominguez
Accomodate for timer added in blockFetchLogic
bc2bb70
@facundominguez
Have the peer simulator use the default grace period for chainsel sta…
62981db 
…rvations
@amesgen
ChainSync client: disconnect if stuck and not better than selection
1c6498e 
TODO better docs
@facundominguez
Shift point schedule times before giving the schedules to tests
4c212aa
@facundominguez
Allow to run the decision logic once after the last tick in the block…
42b9ff4 
…fetch leashing attack
@facundominguez
Update LoP tests to run 1000 times each
e73e43a
@facundominguez
Run more repetitions of LoE tests
aeb3290
@facundominguez
Print timestamps for node restarts
1ff5343
@facundominguez
Disable boring timeouts in the node restart test
99edbed
@facundominguez
Wait sufficiently long after restarting the node at the end of a test
499a95d
@facundominguez
Don't let GDD drop candidates that do not intersect with the selection
db3eb9f
@amesgen
Genesis tests: remove outdated comment
8eb4ea2
@amesgen
disableBoringTimeouts: don't consider canAwaitTimeout boring
833d2ec 
This is relatively tight by default (10s), and applies eg to adversaries that
simply stop sending headers
@facundominguez
Disable canAwaitTimeout again in the timed leashing attack
83ff29e
@facundominguez
Document treatment of fragments with no intersection with the selecti…
3d65fb1 
…on in GDD
@amesgen
fixup! ChainSync client: disconnect if stuck and not better than sele…
6a184e5 
…ction
@facundominguez
Edit note on truncation of candidate fragments
c750764
@facundominguez
Expand the comments motivating DynamoInitState and ObjectorInitState
8eaf5dc
@facundominguez
Expect CandidateTooSparse in gdd tests
c94e8ef
@facundominguez
Run CSJ and gdd tests more times by default
39b4877
@facundominguez
Add a notice about untracked delays in the node restart test
0f22ff1
@facundominguez
Remove redundant empty window check from the GDD
ab33a03
@amesgen
fixup! ChainDB: let the BlockFetch client add blocks asynchronously
23542f9
@nbacquey
Introduce peersOnlyAdversary and classify abnormal test peers as ad…
d15230e 
…versarial
@Niols
Document all tests that did not have documentation
bcb2c11
@nbacquey nbacquey added do-not-merge Genesis PRs related to Genesis testing and implementation labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfrisby nfrisby Awaiting requested review from nfrisby nfrisby will be requested when the pull request is marked ready for review nfrisby is a code owner

@jasagredo jasagredo Awaiting requested review from jasagredo jasagredo will be requested when the pull request is marked ready for review jasagredo is a code owner

@amesgen amesgen Awaiting requested review from amesgen amesgen will be requested when the pull request is marked ready for review amesgen is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk will be requested when the pull request is marked ready for review fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales will be requested when the pull request is marked ready for review dnadales is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge Genesis PRs related to Genesis testing and implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbacquey @facundominguez @Niols @amesgen