Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut releases for Node 8.5 #377

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Cut releases for Node 8.5 #377

merged 2 commits into from
Sep 28, 2023

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Sep 27, 2023 •
edited
Loading

Also inlcudes changelog entries for #366 and the first commit in #323 (second commit was reverted in #362).

@amesgen amesgen mentioned this pull request Sep 27, 2023
Merged
Base automatically changed from amesgen/ledger-conway-1.9 to main September 27, 2023 16:45
@amesgen amesgen force-pushed the amesgen/release-for-node-8.5 branch 2 times, most recently from 22d4fa4 to c31d9e7 Compare September 27, 2023 16:49
@amesgen amesgen marked this pull request as ready for review September 27, 2023 16:49
@amesgen amesgen requested a review from a team as a code owner September 27, 2023 16:49
nfrisby
nfrisby approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Disclaimer:

  • I pointed out that the changelog labels and the actual version changes seem incoherent (patch versus non-breaking), but I trust you to resolve that without another round of review.

  • I see that some of the changelog content here is not arriving via scriv. I did not check whether what you wrote covers all PRs that were missing their changelog fragments.

@amesgen
Copy link
Member Author

amesgen commented Sep 28, 2023 •
edited
Loading

I see that some of the changelog content here is not arriving via scriv. I did not check whether what you wrote covers all PRs that were missing their changelog fragments.

Thanks for pointing that out, I updated the PR description to mention that. That also reminds me to fix https://github.com/input-output-hk/ouroboros-consensus/actions/runs/6328991203/job/17188358397?pr=377 (which is supposed to catch PRs without changelog entries, but it is currently always green).

@amesgen
check-cabal-files.sh: exclude asserts.cabal
d9c6492 
This suddenly started failing on CI even though this file has been there for
several weeks already 🤔
@amesgen
Cut releases for Node 8.5
71e8877 
ouroboros-consensus-0.12.0.0
ouroboros-consensus-diffusion-0.8.0.1
ouroboros-consensus-protocol-0.5.0.7
ouroboros-consensus-cardano-0.10.0.0
@amesgen amesgen added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit e3917f6 Sep 28, 2023
8 of 11 checks passed
@amesgen amesgen deleted the amesgen/release-for-node-8.5 branch September 28, 2023 08:14
@amesgen amesgen mentioned this pull request Sep 29, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfrisby nfrisby nfrisby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amesgen @nfrisby