Merge #3816

3816: Disable unneeded assertion r=bolt12 a=bolt12 # Description This PR fixes #3778 and #3748. It just disables an unneeded assertion that checks if the peer that is getting promoted is a member of the `KnownPeer` set. The reason this assertion is unneeded is because it is possible to reach that point of the code and the peer is not a member of the set due to race conditions. That's why there's an `if` guard to cover for that case. Co-authored-by: Armando Santos <[email protected]>
IntersectMBO · Jun 27, 2022 · a95be8e · a95be8e
2 parents 9d07323 + e731021
commit a95be8e
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor/ActivePeers.hs b/ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor/ActivePeers.hs
@@ -292,7 +292,6 @@ jobPromoteWarmPeer PeerSelectionActions{peerStateActions = PeerStateActions {act
                              }
                            _now ->
 
-        assert (peeraddr `KnownPeers.member` knownPeers st) $
         if peeraddr `EstablishedPeers.member` establishedPeers st
           then
             let activePeers' = Set.insert peeraddr activePeers in
@@ -316,7 +315,6 @@ jobPromoteWarmPeer PeerSelectionActions{peerStateActions = PeerStateActions {act
               decisionJobs  = []
             }
 
-
 ----------------------------
 -- Active peers above target
 --