PIR Generators

[MaximilianAlgehed]

This PR introduces QuickCheck generators for PIR.

Pre-submit checklist:

• Branch
  • Tests are provided (if possible)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
  • Relevant tickets are mentioned in commit messages
  • Formatting, materialized Nix files, PNG optimization, etc. are updated
• PR
  • (For external contributions) Corresponding issue exists and is linked in the description
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested

[michaelpj]

What's the plan here? Are you planning to tidy this up more, or do you want a review right now?

[MaximilianAlgehed]

This needs a bit more tidying up before you need to look at it.

…

On Wed, 27 Apr 2022, 11:36 Michael Peyton Jones, ***@***.***> wrote: What's the plan here? Are you planning to tidy this up more, or do you want a review right now? — Reply to this email directly, view it on GitHub <#4559 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBPPQIMT7RM4A2VTT7LUH3VHEDC7ANCNFSM5UOH3ILA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[effectfully]

I'm almost done reviewing and addressing comments (I only have one more builtins-related thing in mind) on the types part of this PR. I've created a separate PR for it: #4880.

@MaximilianAlgehed take a look at that PR if you feel like it.

[MaximilianAlgehed]

Ok perfect! I'll get on top of your documentation requests and I'll bump th negativeVars business to the top of my list and let you know what's going on there!

…

On Mon, 11 Jul 2022, 14:51 effectfully, ***@***.***> wrote: Ok, I'm a little bit lost as to where we are at with the types stuff. Should we perhaps have a short meeting this week to try to synch on where we are an prioritise things so we can start to get stuff merged? @michaelpj <https://github.com/michaelpj> and @effectfully <https://github.com/effectfully> I've updated your code in a number of ways and got a much better understanding of how it works. Also spent quite a bunch of time debugging the issue with the generators. Now I'm ready to actually go line by line through the code. The code is clever and there's plenty of it, hence it takes me a lot of time to internalize and tweak it (a half of my work time every week is dedicated to working through this PR). My only concern so far is the negativeVars business <#4559 (comment)> that looks wrong. I'm also curious how it prevents the non-termination issue given that it seems to be very easy to break the logic of negativeVars and the generators easily produce way fancier types. Plus I don't remember seeing a generated recursive data type... But maybe I just forgot. Anyhow, I wanted to look into that too. I also had a couple of documentation requests: one about the shrinking order of kinds (Michael requested that as well) and this <#4559 (comment)> one. Summarizing, I'm actively working through the code and I'm not blocked anywhere, so I don't feel like we need a call, but if you feel otherwise, let's have a call. — Reply to this email directly, view it on GitHub <#4559 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBPPQMQSYCJJQKOPYI3FC3VTQKDZANCNFSM5UOH3ILA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[effectfully]

@MaximilianAlgehed I think you're looking at some old comment. You've already addressed negativeVars and you've addressed all of my documentation requests as far as I remember (thank you for all of that!). I concluded that we have enough here for the types part to get merged, so I created a PR with only the types part with the intention to merge it, however Michael left another bunch of dozens of comments and I'm addressing those there. No activity is happening in this PR, so please don't spend your time fulfilling any requests here as we moved all activity to #4880. I'll ping you explicitly there on every comment that requires your attention (it's a fairly small percentage of comments I think, I'm mostly addressing things by myself). Hope that makes sense.

[effectfully]

@MaximilianAlgehed the types part of this PR is merged! I'm now looking into the terms part.

[MaximilianAlgehed]

Good news!

[effectfully]

The term generators are merged too! There's still a lot to do, but that's for follow-ups.

Closing this PR. Thanks a lot @MaximilianAlgehed, for the code, for all the help and for patience!

[MaximilianAlgehed]

Great! Let me know if you need any more feedback or information!