Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kwxm/bls12-381/prototype (PLT-192, PLT-1557, PLT-1554, etc). #5231
Kwxm/bls12-381/prototype (PLT-192, PLT-1557, PLT-1554, etc). #5231
Changes from all commits
0020b29
7e0de43
3927e15
4ade080
56589d9
a592101
26b01ec
1bb2753
099ba8c
bf30d3f
4956ed9
b1b1b0d
2354352
a81447e
3cfe6db
51bbb93
dd3b6d3
48a0f18
aaa8ec9
378264f
39d1804
236b2cb
c977559
0b0048e
c17d0b8
cd8c1c5
994b478
fd18459
1c219e7
ba59233
1a18aff
7e812f2
6216a1a
b102e4a
54087c7
b337f23
196f6ac
a1e1c48
00c48ee
c276129
5b4a6fb
d5c5660
c292e0e
aaf2abc
e75b9a2
8de27a1
4d43ca9
fdf8f6f
c3bea5f
640fdd7
9365d43
2ae1323
4b22cbe
fd8f5c0
05a9f37
a5c5386
384add7
fa3ae48
b9ba88c
0f25b60
3a13bbc
0b854bd
8041694
bc76516
5f5f705
7ef1fe1
8d67d51
efd3d1f
40b55ae
52c8d63
0242dd3
9a761c2
b8c0a95
5cd1e06
cbde413
4d4280d
086b83a
ffe0130
94176b7
a4140ff
d423a47
1963ff8
251ef9c
9cc3f61
e451055
fa4b195
82237c5
fc02f08
885747e
edfabad
7771982
f1581d5
fa29bc1
e17860c
80db5e7
2a2659e
8385fbf
0370055
06d78c1
575f35d
616608c
73a3278
067b444
e0bd999
3d89f5d
9affbaa
d238be1
b8d6690
37321b8
8d5080e
eda34de
2ffe630
aeaec35
ea3064b
51b244f
82e659a
5acda2d
98caea1
de4ca72
a91d8a3
9a2e840
79bdd9e
c67dda5
4521caf
9c6b92a
2319ad0
311d000
18cf9f6
6585a98
0e1c8c5
5dfd770
02d6bf3
fe45053
6cc73e3
6d969d8
a89677e
bf07f99
f25bceb
930f578
dfbf702
5292de0
2038ca0
1c182de
b0c8f7f
6916df4
100f301
8c74593
50d0e93
a520986
6f0698a
a71be07
483cdcd
a077b9d
ce46a04
1187e3f
9316d19
228de87
17f6a86
a345dc7
00e0be0
6970cbd
3a7ed24
f121dd6
8957ee1
d83721a
5fa04f5
50e5040
c1191cb
5fc950c
6630d15
45ff422
16bf911
c9fd616
f2294bc
18f28a0
7f897b8
1ac1ae6
332773f
8b0db0b
aed2c6c
ccdac92
2b1b382
10c5e47
1f93366
4aee59e
bb5b70b
9f1ccb6
4360585
610ee51
2bae2c7
748b666
8f9b2d7
0460f4e
bf30c36
fa8b323
d71023e
5f136e7
2920bc5
f408615
fe62965
513f4e6
eed55b5
4f94d7f
946ee31
2b9ac9f
af2e99d
e5bfc61
2c733ab
85ec23d
b3eb0f3
3a859cc
3d10333
7daa1d5
198816d
0e97668
2b0f142
75c8cfe
19563fa
651f525
aa41b37
310cfe0
57dc567
fcc4551
9a07a5a
e88aa44
17ff8f3
df8f19b
e67e029
29a78e3
646b7e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also add some budget tests for these so we can see how much they end up costing deterministically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so I think what I'm suggesting is basically to make this into a test suite with budget tests instead. Maybe the output is less easy to read, IDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also check in the output as a golden file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big 👍 from me on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated from somewhere else, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, from
plutus-benchmark/ed25519-throughput/Main.hs
. There's a ticket to put these somewhere global, but it hasn't been done yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grumble