Kwxm/bls12 381/minor fixes #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
approved these changes
Jun 1, 2023
| @@ -274,7 +276,7 @@ groth16Verify | |||
| :: BuiltinByteString -- G1 | |||
| -> BuiltinByteString -- G2 | |||
| -> BuiltinByteString -- G2 | |||
| -> BuiltinByteString -- G1 | |||
| -> BuiltinByteString -- G2 | |||
There was a problem hiding this comment.
Seems like it might be worth having some newtypes here idk?
There was a problem hiding this comment.
Yeah, I was a bit confused when I looked at that today. These types are wrapped in newtypes elsewhere in this file, but not here. I think I did that because what we're really wanting to measure here is what happens on the chain, and having newtypes here would cost a little more. I think we get delay or something in the uplc if we do that, which I was slightly surprised by when I found out. I could be wrong about that though: I'll check.
kwxm
commented
Jun 1, 2023
| instance ExMemoryUsage BLS12_381.Pairing.MlResult where | ||
| memoryUsage _ = singletonRose . unsafeToSatInt $ BLS12_381.Pairing.mlResultMemSizeBytes `div` 8 | ||
| memoryUsage _ = mlResultElementCost |
There was a problem hiding this comment.
The stuff above is in response to this comment from @effectfully .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just responding to a couple of small things raised in the PR comments; the main branch got merged while I was fixing these.