Bitwise operations

plutus-core/changelog.d/20240523_124004_koz.ross_bitwise_2.md

@@ -0,0 +1,41 @@
+<!--
+A new scriv changelog fragment.
+
+Uncomment the section that is right (remove the HTML comment wrapper).
+-->
+
+<!--
+### Removed
+
+- A bullet item for the Removed category.
+
+-->
+### Added
+
+- Implementation and tests for primitive operations in [this
+  CIP](https://github.com/mlabs-haskell/CIPs/blob/koz/bitwise/CIP-XXXX/CIP-XXXX.md)
+
+<!--
+### Changed
+
+- A bullet item for the Changed category.
+
+-->
+<!--
+### Deprecated
+
+- A bullet item for the Deprecated category.
+
+-->
+<!--
+### Fixed
+
+- A bullet item for the Fixed category.
+
+-->
+<!--
+### Security
+
+- A bullet item for the Security category.
+
+-->

plutus-core/plutus-core.cabal

@@ -94,6 +94,7 @@ library
     PlutusCore.Arity
     PlutusCore.Bitwise.Convert
     PlutusCore.Bitwise.Logical
+    PlutusCore.Bitwise.Other
     PlutusCore.Builtin
     PlutusCore.Builtin.Debug
     PlutusCore.Builtin.Elaborate
@@ -417,6 +418,7 @@ test-suite untyped-plutus-core-test
     DeBruijn.Spec
     DeBruijn.UnDeBruijnify
     Evaluation.Builtins
+    Evaluation.Builtins.Bitwise
     Evaluation.Builtins.BLS12_381
     Evaluation.Builtins.BLS12_381.TestClasses
     Evaluation.Builtins.BLS12_381.Utils

plutus-core/plutus-core/src/PlutusCore/Default/Builtins.hs

@@ -28,6 +28,7 @@ import PlutusCore.Pretty (PrettyConfigPlc)
 
 import PlutusCore.Bitwise.Convert as Convert
 import PlutusCore.Bitwise.Logical as Logical
+import PlutusCore.Bitwise.Other as Other
 import PlutusCore.Crypto.BLS12_381.G1 qualified as BLS12_381.G1
 import PlutusCore.Crypto.BLS12_381.G2 qualified as BLS12_381.G2
 import PlutusCore.Crypto.BLS12_381.Pairing qualified as BLS12_381.Pairing
@@ -161,6 +162,11 @@ data DefaultFun
     | ReadBit
     | WriteBits
     | ReplicateByteString
+    -- Bitwise
+    | BitwiseShift
+    | BitwiseRotate
+    | CountSetBits
+    | FindFirstSetBit
     deriving stock (Show, Eq, Ord, Enum, Bounded, Generic, Ix)
     deriving anyclass (NFData, Hashable, PrettyBy PrettyConfigPlc)
 
@@ -1888,6 +1894,40 @@ instance uni ~ DefaultUni => ToBuiltinMeaning uni DefaultFun where
             byteStringReplicateDenotation
             (runCostingFunTwoArguments . unimplementedCostingFun)
 
+    -- Bitwise
+
+    toBuiltinMeaning _semvar BitwiseShift =
+        let bitwiseShiftDenotation :: BS.ByteString -> Int -> BS.ByteString
+            bitwiseShiftDenotation = Other.bitwiseShift
+            {-# INLINE bitwiseShiftDenotation #-}
+        in makeBuiltinMeaning
+            bitwiseShiftDenotation
+            (runCostingFunTwoArguments . unimplementedCostingFun)
+
+    toBuiltinMeaning _semvar BitwiseRotate =
+        let bitwiseRotateDenotation :: BS.ByteString -> Int -> BS.ByteString
+            bitwiseRotateDenotation = Other.bitwiseRotate
+            {-# INLINE bitwiseRotateDenotation #-}
+        in makeBuiltinMeaning
+            bitwiseRotateDenotation
+            (runCostingFunTwoArguments . unimplementedCostingFun)
+
+    toBuiltinMeaning _semvar CountSetBits =
+        let countSetBitsDenotation :: BS.ByteString -> Int
+            countSetBitsDenotation = Other.countSetBits
+            {-# INLINE countSetBitsDenotation #-}
+        in makeBuiltinMeaning
+            countSetBitsDenotation
+            (runCostingFunOneArgument . unimplementedCostingFun)
+
+    toBuiltinMeaning _semvar FindFirstSetBit =
+        let findFirstSetBitDenotation :: BS.ByteString -> Int
+            findFirstSetBitDenotation = Other.findFirstSetBit
+            {-# INLINE findFirstSetBitDenotation #-}
+        in makeBuiltinMeaning
+            findFirstSetBitDenotation
+            (runCostingFunOneArgument . unimplementedCostingFun)
+
     -- See Note [Inlining meanings of builtins].
     {-# INLINE toBuiltinMeaning #-}
 
@@ -2023,6 +2063,11 @@ instance Flat DefaultFun where
               WriteBits                       -> 80
               ReplicateByteString             -> 81
 
+              BitwiseShift                    -> 82
+              BitwiseRotate                   -> 83
+              CountSetBits                    -> 84
+              FindFirstSetBit                 -> 85
+
     decode = go =<< decodeBuiltin
         where go 0  = pure AddInteger
               go 1  = pure SubtractInteger
@@ -2106,6 +2151,10 @@ instance Flat DefaultFun where
               go 79 = pure ReadBit
               go 80 = pure WriteBits
               go 81 = pure ReplicateByteString
+              go 82 = pure BitwiseShift
+              go 83 = pure BitwiseRotate
+              go 84 = pure CountSetBits
+              go 85 = pure FindFirstSetBit
               go t  = fail $ "Failed to decode builtin tag, got: " ++ show t
 
     size _ n = n + builtinTagWidth

plutus-core/plutus-ir/src/PlutusIR/Transform/RewriteRules/CommuteFnWithConst.hs

@@ -130,11 +130,15 @@ isCommutative = \case
   IntegerToByteString             -> False
   ByteStringToInteger             -> False
   -- Currently, this requires commutativity in all arguments, which the
-  -- logical operations are not.
+  -- logical and bitwise operations are not.
   AndByteString                   -> False
   OrByteString                    -> False
   XorByteString                   -> False
   ComplementByteString            -> False
   ReadBit                         -> False
   WriteBits                       -> False
   ReplicateByteString             -> False
+  BitwiseShift                    -> False
+  BitwiseRotate                   -> False
+  CountSetBits                    -> False
+  FindFirstSetBit                 -> False