Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File mru #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

File mru #148

wants to merge 2 commits into from

Conversation

barbyfernicola
Copy link

Submitting a Pull Request based on Conversation I had with Dave Hull to update FileMRU.cs to support Office 2016/O365 Instances and fix some issues.

  • Issue: Multiple Office Version Registry keys can exist, existing code was identifying first one and exiting (i.e. 11, 12, 14 <- stop at 11. Resolution: Moved lookup of OfficeKey and Versions to File MRU since to properly identify what versions of office have the valid version/Recent Items, need to loop through each version
  • Issue: Newer versions of Office i.e. Office 2016 can have other configuration registry values underneath File MRU Resolution: Changed the if statement from Not "Max Displays" to Begins With Item
    -Issue: "Microsoft Office is not installed on this system" message was deceiving, updated to "Microsoft Office is not installed on this system or has not been opened by this User" since the existence of the registry key could just be that the user has not opened Office
  • Issue: "Office 365 versions of Office store their Recent Items underneath \UserMRU\AD_\FileMRU - updated to support new location

Support for Multiple Office Key Versions
…nd UserMRU/FileMRU Recent Items location which occurs with Newer Versions of Office/O365
@jaredcatkinson
Copy link
Member

Awesome! Thanks for submitting the PR! I am on-site today and tomorrow, so I will take a look this weekend and hopefully get this merged!

@bwhite00
Copy link

bwhite00 commented Jan 4, 2018

Hi Jared, were you able to review this PR for inclusion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants