Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search highlight #96

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Search highlight #96

merged 6 commits into from
Jul 11, 2023

Conversation

kylehuynh205
Copy link
Contributor

About this PR

  • Switch Advanced Search from contrib branch to 1.0.0-beta1 version
  • Enable Search highlight feature for Advanced Search module
  • Modifying the configuration of Solr server and Search API index for the highlight
  • Add Search: Excerpt in search views

image

image

kylehuynh205 and others added 2 commits June 21, 2023 13:58
@kylehuynh205
Enable Search hightlight settings for Search API
b197228 
Added Search hightlight field for search views
Change Advanced Search module to the beta release
@kylehuynh205
Update composer.lock
c31f335
@kylehuynh205 kylehuynh205 mentioned this pull request Jun 21, 2023
Open
@rosiel
Copy link
Contributor

rosiel commented Jun 27, 2023

Why is the word "search" being highlighted?

kylehuynh205 added a commit to kylehuynh205/islandora-starter-site that referenced this pull request Jun 30, 2023
@kylehuynh205
Merge branch 'search_highlight' of github.com:kylehuynh205/islandora-…
bea770b 
…starter-site into islandora_group

* 'search_highlight' of github.com:kylehuynh205/islandora-starter-site:
  Update version of Advanced Search include fixes for https://github.com/digitalutsc/advanced_search/issues/33 and Islandora-Devops#96 (comment)
  Update composer.lock
  Enable Search hightlight settings for Search API Added Search hightlight field for search views Change Advanced Search module to the beta release
  Bump JWT.
  Update jwt

# Conflicts:
#	composer.lock
@rosiel
Copy link
Contributor

rosiel commented Jul 5, 2023

A few perhaps-too-harsh criticisms:

  • it's difficult to parse the keywords-in-context (KWIC) snippet because unlike the other elements (fields) that show up, it has no label. KWIC is a very industry term and people won't know it, I'm not sure what to call it. As is, it runs into the Description which is misleading.
  • The keywords often appear in the other exposed fields but are not highlighted there. This seems counter-intuitive.
  • If you search within one of the advanced search field-specific searches, for example "Steve" within Names, the keywords-in-context snippet includes content from other fields as well and implies you're doing a search of everything.

Does the community have any ways of improving on this? I'll ask in the mailing list.

@rosiel
Copy link
Contributor

rosiel commented Jul 6, 2023

I can change the settings so that the other search results fields display highlighting (at least, the full text ones). I also created a label for the field and gave it the same field__item and field__label classes that cause the other labels to show up as bold.

Screenshot 2023-07-06 at 9 15 30 AM

But the new problem is that when listing a collection, the search results excerpts show up. If I turn them off using the "Create excerpt even if no search keys are available" option, then they never show up (presumably because it doesn't understand our faceted search as a search key).

@rosiel
Copy link
Contributor

rosiel commented Jul 10, 2023

I have a PR against your branch if you're ok with those changes.
kylehuynh205#3

@rosiel rosiel merged commit 8ba92af into Islandora-Devops:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylehuynh205 @rosiel