Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how settings.php gets appended #403

Merged

Conversation

aOelschlager
Copy link
Contributor

For issue #401

This removes the update-settings make command from the starter variants and replaces the default_settings.txt in the starter site. This is how the isle site template does it's configuration.

To test run make starter_dev or make starter.

@aOelschlager aOelschlager marked this pull request as draft August 8, 2024 18:11
@aOelschlager
Copy link
Contributor Author

Make starter_dev works but make starter errors out.

@alxp
Copy link
Contributor

alxp commented Aug 9, 2024

Confirm that make starter_dev works for me.

make starter seems to fail on Drupal install looking for the database, but I was able to immediately docker compose exec mariadb with-contenv bash and run mysql and see the database was created. Running make starter again continues the build. So I don't think the error is related to the problem addressed in this PR>

@aOelschlager
Copy link
Contributor Author

That fixed the error on make starter. This works but it's still calling the update-settings make command during make hydrate. If I remove that command from make hydrate then make starter and make starter_dev white screen on adding repository objects or media. I think it has to do with the fedora url not being set. I should have that fixed here soon.

@aOelschlager
Copy link
Contributor Author

This is ready for review now.

Copy link
Contributor

@alxp alxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested make starter and make starter_dev and they both worked.

@alxp alxp merged commit 8b9e384 into Islandora-Devops:development Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants