Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update crayfits to symfony 5.4 #180

Draft
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

joecorall
Copy link
Member

@joecorall joecorall commented Dec 7, 2023

GitHub Issue: roblib/CrayFits#13

  • Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.)

What does this Pull Request do?

Updates the crayfits microservice to use symfony 5.4 libraries. This is to remove the fopen call to the fcrepo URL, which results in a server error when using a locally signed CA (i.e. with the dev profile in isle-site-template)

TODO

Still some pending tasks before this PR can be ready for review

  • Add logging functionality back, using stderr instead of a log file in the container
  • Fixup public/index.php to be more inline with other crayfish services
  • Make any other changes so crayfits is more similar to other crayfish services

What's new?

A in-depth description of the changes made by this PR. Technical details and possible side effects.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant