Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP versions and Travis setup #73

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Oct 25, 2018

GitHub Issue: Islandora/documentation#940

What does this Pull Request do?

Change the versions of PHP to test against and the Travis setup.

What's new?

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Travis should pass.

Interested parties

@Islandora-CLAW/committers

@whikloj
Copy link
Member Author

whikloj commented Oct 25, 2018

@dannylamb I think this will need to go in before your travis-badge one. If it passes.

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #73 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     97.33%   97.01%   -0.32%     
  Complexity       12       12              
============================================
  Files             1        1              
  Lines            75       67       -8     
============================================
- Hits             73       65       -8     
  Misses            2        2
Impacted Files Coverage Δ Complexity Δ
src/FedoraApi.php 97.01% <0%> (-0.32%) 12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e108c7...a3001f6. Read the comment docs.

@dannylamb
Copy link
Contributor

@whikloj Can you update this so we get the latest version of ml/JsonLD now that your PR has been merged?

@dannylamb dannylamb merged commit fc60e9c into Islandora:master Nov 21, 2018
@whikloj whikloj deleted the issue-940 branch December 17, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants