Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention fcrepo.session.timeout property. #2158

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Mention fcrepo.session.timeout property. #2158

merged 4 commits into from
Sep 7, 2022

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Aug 29, 2022

Purpose / why

Saw this on Slack and thought it should be documented.

What changes were made?

  • mention how to change fcrepo.session.timeout if you're loading large files
  • add headers so that it makes sense and for accessibility.

Verification

Is this accurate?

Interested Parties

@whikloj @ruebot

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@ruebot
Copy link
Member

ruebot commented Aug 29, 2022

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little typo but otherwise makes sense.

@ruebot
Copy link
Member

ruebot commented Sep 6, 2022

@rosiel I added a couple more configuration points in mjordan/islandora_workbench#353 if you want to update this PR with them.

@rosiel rosiel requested a review from whikloj September 6, 2022 14:09
Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more typo (I think), otherwise its good

docs/technical-documentation/uploading-large-files.md Outdated Show resolved Hide resolved
Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj whikloj merged commit 95c58d6 into main Sep 7, 2022
@whikloj whikloj deleted the rosiel-patch-5 branch September 7, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants