Add file access check to IIIF manifest generation. #884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2134
Release pull requests, etc.)
What does this Pull Request do?
Prevent the inclusion of files to which a user may not have access in IIIF manifests.
What's new?
Performs an access check before returning things.
(i.e. Regeneration activity, etc.)? No.
How should this be tested?
Use some mechanism (e.g.,
embargoes
) to apply file access controls, and ensure that multi-page viewers should follow suit (single/non-manifest version handled in Islandora/openseadragon#42).For testing, adding a small
hook_file_access()
blurb to your code somewhere is probably easiest, such as:Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers