Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double-slash from IIIF canvas Ids. #940

Merged
merged 1 commit into from
May 4, 2023

Conversation

alxp
Copy link

@alxp alxp commented May 2, 2023

GitHub Issue: [BUG] islandora_iiif generating incorrect canvas IDs

What does this Pull Request do?

Fixes a bug where canvas Ids in IIIF manifests would have double slashes in the URL.

What's new?

  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? Yes, if code was relying on the existing canvas URLs.

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)

See steps in issue.

Documentation Status

  • Does this change existing behaviour that's currently documented? No
  • Does this change require new pages or sections of documentation? No
  • Who does this need to be documented for? N/A
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers @bibliophileaxe

@adam-vessey

@wgilling wgilling self-requested a review May 3, 2023 17:08
@wgilling
Copy link

wgilling commented May 4, 2023

The code has been reviewed and the id looks good

@wgilling wgilling merged commit 66401ba into 2.x May 4, 2023
@seth-shaw-asu seth-shaw-asu deleted the issue-939-iiif-manifest-canvas-ids branch May 5, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants