Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#41 theme variables #42

Merged
merged 4 commits into from
Mar 6, 2024
Merged

#41 theme variables #42

merged 4 commits into from
Mar 6, 2024

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Mar 5, 2024

What does this Pull Request do?

What's new?

This change adds three new theme variables, and hooks them up to the block class configuration.

  • window_config
    • workspace_config
    • thumbnail_navigation_position
      The first two are arrays and can pass along any configs to the Mirador instantiation JS code to, e.g., remove unwanted UI elements.
  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

After clearing cache, this can be tested by implementing the example hook or block instantiation from the updated README and verifying that Mirador's appearance changes accordingly.

Documentation Status

  • Does this change existing behaviour that's currently documented? No
  • Does this change require new pages or sections of documentation? README updated.
  • Who does this need to be documented for? Developers.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@seth-shaw-asu seth-shaw-asu merged commit 4dcbfc2 into 2.x Mar 6, 2024
@rosiel rosiel deleted the 41-theme-vars branch March 6, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants