Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up for new code sniffs #164

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Feb 19, 2019

JIRA Ticket: No JIRA, work related to Islandora/islandora#714

What does this Pull Request do?

Brings code in line with new code sniffs and cleans up/reuses some testing infrastructure.

How should this be tested?

Mostly watch for a green on Travis and then check that the tests are being run and really passing.

Additional Notes:

Example:

  • Does this change the interface, add a new feature, or otherwise change behaviours that would require updating documentation? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

Interested parties

@jonathangreen @Islandora/7-x-1-x-committers

@jonathangreen
Copy link
Contributor

One quick comment:

Looks good to me otherwise.

Copy link
Contributor

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Starting ⏰.

@jonathangreen jonathangreen merged commit 717353d into Islandora:7.x Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants