Add contrib hal and rdf to composer. Also fix deprecated code. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosiel
changed the title
adam-vessey
approved these changes
Jul 18, 2023
| foreach (\Drupal::moduleHandler()->getImplementations(self::FIELD_MAPPPINGS_HOOK) as $module) { | ||
| $function = $module . '_' . self::FIELD_MAPPPINGS_HOOK; | ||
| foreach ($function() as $field => $mapping) { | ||
| \Drupal::moduleHandler()->invokeAllWith(self::FIELD_MAPPPINGS_HOOK, function (callable $hook, string $module) { |
There was a problem hiding this comment.
Kinda surprised that phpcs isn't complaining about the lack of DI here, but... looks like it might only be from the DrupalPractice suite (that we don't presently run, but possibly should?):
336 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
| | (DrupalPractice.Objects.GlobalDrupal.GlobalDrupal)
... s'yeah, can ignore. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: For a smoother upgrade to Drupal 10, we can start using contributed components now.
What does this Pull Request do?
Makes Upgrade Status a little happier.
What's new?
This mirrors what already happened in #69 on the 3.x branch, but for Drupal 9.
How should this be tested?
Install Upgrade Status and it will tell you there are "Deprecated or obsolete core extensions installed".
With this PR, after a composer update and a cache clear, there shouldn't be.
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers