vstest integration #124
Open
vstest integration #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip allow nested tests misc improvements improve test filtering improve error handling vsconsole test runner
Nsidorenco
force-pushed
the
test-runner
branch
from
2d72a2b
to
9bc7d46
Compare
Nsidorenco
force-pushed
the
test-runner
branch
from
643e37d
to
ea8750e
Compare
|
Hi @Nsidorenco - Great work on this so far! I'm very limited on free time at the moment (essentially I have none!) so this is a big help towards improving this adapter. When I get chance, I'll take a good look at the changes, but at first glance, it looks like it's going in the right direction. |
|
@Issafalcon just take your time 😄 Outside of testing it is relatively feature complete now and should be ready for a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the queries for F# hit so many edge-cases with the different test running and their naming of test that it became easier to just implement the ideas of #90.
Rough draft of a vsconsole-based implementation, where a vstest instance is responsible for test discovery and running tests. Seems to work pretty well and reasonably snappy.
The test discovery logic should probably be cached in some way to avoid discovering test cases for the same dll for every source file.Still a bit of work to be done as well;
for now, the path to both the vstest dll and the test project dlls are (relatively) hard coded andoverall test are entirely missing.Will eventually close #90 and close #82