Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: created coworker-slug #131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: created coworker-slug #131

wants to merge 4 commits into from

Conversation

mikaelaalu
Copy link

Created co-workers slug page, not final design.

@momentiris
Copy link
Collaborator

momentiris commented Nov 26, 2020

Denna är ju inte klar än som sagt. Däremot något vi kan lägga till redan nu är stöd för metadata för varje enskild medarbetare. Det finns en Meta.svelte som vi kan använda till det. Vi vill få in metadata för title, description osv från ghost här.

Copy link
Contributor

@lundeeell lundeeell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Missing some styling, but it works!
Would be nice to indicate somehow that coworker is clickable on index (hover effect or something)

export let coworker
const [workTitle, phone, email] = coworker.custom_excerpt.split('\n')
</script>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing meta-tag. For instance <Meta title="Iteam | Om oss - {coworker.title}" />

@@ -1,59 +0,0 @@
<script context="module">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file hasn't been removed. Just all content :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants