[MOB-6632] [MOB-6633] [MOB-6634] [MOB-6636] Add Iterable embedded manager unit tests #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayyanchira
reviewed
Aug 28, 2023
| manager.syncMessages { } | ||
|
|
||
| XCTAssertTrue(delegate1Called, "Delegate 1 should have been notified.") | ||
| XCTAssertTrue(delegate2Called, "Delegate 2 should have been notified.") |
| ]) | ||
| manager.syncMessages { } | ||
|
|
||
| XCTAssertFalse(delegateCalled, "Delegate should not have been notified after being removed.") |
| } | ||
|
|
||
| override func getEmbeddedMessages() -> IterableSDK.Pending<IterableSDK.PlacementsPayload, IterableSDK.SendRequestError> { | ||
| if invalidApiKey { |
There was a problem hiding this comment.
A little confused here. Does the actual getMessages not get called in the tests?
There was a problem hiding this comment.
@Ayyanchira if we didn't override getEmbeddedMessages(), the test would attempt to call the API. As this is only a unit test (and not an endpoint test), we don't want to make actual API calls, as that could introduce flakiness and external dependency.
Ayyanchira
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
Had to make a couple minor adjustments to the actual manager to add/remove forerground notification observers (they hadn't been implemented yet), and to add onDeinit closure, which we can then observe in tests.