Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping PrivacyInfo in podspec file #760

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

silvgabriel
Copy link

@silvgabriel silvgabriel commented Apr 9, 2024

Mapping PrivacyInfo in podspec file

🔹 Jira Ticket(s)

✏️ Description

Please provide a brief description of what this pull request does.

@silvgabriel silvgabriel changed the title Mapping xcprivacy in podspec file Mapping PrivacyInfo in podspec file Apr 9, 2024
@silvgabriel
Copy link
Author

silvgabriel commented Apr 9, 2024

You forgot to map the PrivacyInfo file type in the podspec

@Ayyanchira
Copy link
Member

Thanks for the PR!

I had tested an App with SPM generated Privacy report which had data from SDK's manifest.

@silvgabriel, does the Cocoapods based project not pull privacy manifest from SDK when generating report? If so, does this change rectify the issue?

@silvgabriel
Copy link
Author

silvgabriel commented Apr 10, 2024

Hi @Ayyanchira

SPM is working well because you only map the Resources folder and everything we have inside this folder will appear in the project.
In the CocoaPod podspec you map the file types in the resource part and the xcprivacy type is missing, so the private manifest file does not appear/mapped.
Cocoapods will just pull the files into the generated report that is mapped into the podspec.

This PR fixes the CocoaPod part, check the image below, it is the Iterable-iOS-SDK pod installed in my project:
image

Another way to resolve this is to equalize the podspec with the SPM file by mapping just the Resource folder (without specifying types) so the CocoaPods will map all files inside the resource folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants