Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for fetching new JWT prior to calling merge #849

Conversation

megha-iterable
Copy link

@megha-iterable megha-iterable commented Oct 23, 2024

Jira Ticket(s)

Description

Please provide a brief description of what this pull request does.

Test Steps

Video attached to the ticket, See a JIRA ticket for the video

@megha-iterable megha-iterable force-pushed the feature/MOB-9746-Use-destinationUser-JWT-when-calling-merge branch from cbc779a to 3c81c88 Compare October 23, 2024 09:25
@megha-iterable megha-iterable force-pushed the feature/MOB-9746-Use-destinationUser-JWT-when-calling-merge branch from 461b804 to f3a0799 Compare October 23, 2024 10:33
@megha-iterable megha-iterable marked this pull request as ready for review October 23, 2024 10:52
}
} else {
handleAuthFailure(failedAuthToken: nil, reason: .authTokenNull)
scheduleAuthTokenRefreshTimer(interval: getNextRetryInterval(), successCallback: onSuccess)
authToken = retrievedAuthToken
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this cleaner? I think calling once is better.

Copy link
Collaborator

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making changes to this PR per our discussion

  • removing GenerateJWTSuccess callback in favor of using success callback already implemented
  • creating a new function attemptMergeAndEventReplay that takes in email/userI
  • passing in email/userId into onLogin function to call attemptMergeAndEventReplay within onLogin function

@evantk91 evantk91 marked this pull request as draft October 28, 2024 17:33
@evantk91 evantk91 marked this pull request as ready for review October 30, 2024 16:01
@evantk91 evantk91 merged commit 9ed3cdd into feature/itbl_track_anon_user Oct 30, 2024
2 checks passed
@evantk91 evantk91 deleted the feature/MOB-9746-Use-destinationUser-JWT-when-calling-merge branch October 30, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants