-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for fetching new JWT prior to calling merge #849
Merged
evantk91
merged 5 commits into
feature/itbl_track_anon_user
from
feature/MOB-9746-Use-destinationUser-JWT-when-calling-merge
Oct 30, 2024
Merged
Added support for fetching new JWT prior to calling merge #849
evantk91
merged 5 commits into
feature/itbl_track_anon_user
from
feature/MOB-9746-Use-destinationUser-JWT-when-calling-merge
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megha-iterable
force-pushed
the
feature/MOB-9746-Use-destinationUser-JWT-when-calling-merge
branch
from
October 23, 2024 09:25
cbc779a
to
3c81c88
Compare
…to make capture semantics explicit
megha-iterable
force-pushed
the
feature/MOB-9746-Use-destinationUser-JWT-when-calling-merge
branch
from
October 23, 2024 10:33
461b804
to
f3a0799
Compare
evantk91
approved these changes
Oct 23, 2024
} | ||
} else { | ||
handleAuthFailure(failedAuthToken: nil, reason: .authTokenNull) | ||
scheduleAuthTokenRefreshTimer(interval: getNextRetryInterval(), successCallback: onSuccess) | ||
authToken = retrievedAuthToken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this cleaner? I think calling once is better.
…-destinationUser-JWT-when-calling-merge
evantk91
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making changes to this PR per our discussion
- removing GenerateJWTSuccess callback in favor of using success callback already implemented
- creating a new function attemptMergeAndEventReplay that takes in email/userI
- passing in email/userId into onLogin function to call attemptMergeAndEventReplay within onLogin function
…-destinationUser-JWT-when-calling-merge
evantk91
deleted the
feature/MOB-9746-Use-destinationUser-JWT-when-calling-merge
branch
October 30, 2024 16:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket(s)
Description
Test Steps