Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to draw shadow behind toasts #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

woelper
Copy link

@woelper woelper commented Sep 27, 2024

This PR exposes the option to use a shadow on notifications in order to improve visibility. The shadow is optional.

@bircni
Copy link
Contributor

bircni commented Sep 27, 2024

Maybe also extend the examples to show the shadow

@woelper
Copy link
Author

woelper commented Sep 27, 2024

Maybe also extend the examples to show the shadow

I added a button to add shadows. Hope this works for you!

@bircni
Copy link
Contributor

bircni commented Sep 27, 2024

Could not spot any difference
with shadow:
image

without shadow:
image

@bircni
Copy link
Contributor

bircni commented Sep 27, 2024

I suggest changing the examples like this:
all.rs.txt

@woelper
Copy link
Author

woelper commented Sep 27, 2024

I suggest changing the examples like this: all.rs.txt

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants