Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The prerelases published on each PR merge don't match the future version #345

Closed
pygy opened this issue Jun 5, 2022 · 3 comments
Closed

The prerelases published on each PR merge don't match the future version #345

pygy opened this issue Jun 5, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@pygy
Copy link
Contributor

pygy commented Jun 5, 2022

In Mithril, the release PR has already beeen bumped to v3.0.0.

However, the prereleases over at npm are based off v2.2.3. This seems wrong...
@JAForbes JAForbes added the bug Something isn't working label Jun 5, 2022
@JAForbes
Copy link
Owner

JAForbes commented Jun 5, 2022

Yeah interesting, I'll take a look

@JAForbes JAForbes mentioned this issue Jun 5, 2022
Merged
12 tasks
@JAForbes
Copy link
Owner

JAForbes commented Jun 5, 2022

An oversight on my part, mithril having a default branch of master (instead of main) requires --target to be explicitly set.

@pygy
Copy link
Contributor Author

pygy commented Jun 6, 2022 •
edited
Loading

Yes, thanks for the fix :-)

This makes me think we could easliy rename that branch to main.

@JAForbes JAForbes mentioned this issue Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pygy @JAForbes