-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release - v3.0.0 #2776
Release - v3.0.0 #2776
Conversation
⚠⚠⚠ Hey @JAForbes, did you mean to open this against |
This hasn't been true since v2.0
Without specifying target:master the prerelease version calculation would be incorrect.
* Add back CI, remove ospec as a run-time dependency * Fix the lint:docs errors * Add back ospec for now, with a compatible version
* Actually remove ospec from the main code base (it is still used as a dev-dependency) * fix a copy error Co-authored-by: Barney Carroll <[email protected]> Co-authored-by: Barney Carroll <[email protected]>
…other review concerns
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
@JAForbes the pr action failed here, not sure what happens or if I can re-run it safely... |
Re-ran it and passed. I've seen it before and raised it with github support. Sometimes the PATCH endpoint returns a 404 erroneously. To answer your question its safe to re-run the |
Great, thanks ! |
Bumps [shell-quote](https://github.com/substack/node-shell-quote) from 1.7.2 to 1.7.3. - [Release notes](https://github.com/substack/node-shell-quote/releases) - [Changelog](https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md) - [Commits](https://github.com/substack/node-shell-quote/compare/v1.7.2...1.7.3) --- updated-dependencies: - dependency-name: shell-quote dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [terser](https://github.com/terser/terser) from 4.3.4 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
* [DOM mocks] enable setting element.style * Use the style setter directly
[skip ci]
@JAForbes I messed up with the v2.x branch and accidentally triggered pr-release to run from there, i.e. the wrong branch. It would be nice if there were branch checks before doing irreversible operations (and possibly other idiot proofing measures). Also, from here, how do we fix things up? |
Was the wrong version released as 2.2.3? :O |
Yes, I messed up while setting up the v2.x branch and triggered the It was up for about one hour and a half, I hope it didn't derail your workflow... |
No, not at all, was just testing Mithril when I noticed some changes that I had to investigate 😅 Oh, it's fixed already? Sadly the Mithril CDN link I found on Google as the top result still holds that wrong version: https://cdnjs.com/libraries/mithril :/ |
Oh, thanks for the heads up. Not sure I can solve this on their hand, short of pushing yet another release... cdnjs/packages#1450 ... We'll see how things go over there. |
Release v3.0.0
Changelog
Major Changes
Actually remove ospec from the main code base (@pygy)
It is still used as a
dev-dependency
.Kick promise polyfill (@StephanHoyer)
allow trailing slash for routes - fixes #2763 (@StephanHoyer)
Minor Changes
Bump terser from 4.3.4 to 4.8.1 (@dependabot[bot])
Bumps terser from 4.3.4 to 4.8.1. Changelog. Sourced from terser's changelog. v4.8.1 (backport).
implement m.domFor() and use it internally to move and remove nodes. Fix #2780 (@pygy)
Add
m.domFor(vnode)
. This addsm.domFor(vnode)
as described in #2780 (with a twist to deal with node removal between iterations).Patch Changes
Bypass css text (@pygy)
Shave a few bytes by setting
element.style
directly, rather thanelement.style.cssText
, since the former is now supported everywhere relevant.Fix silent build error in next: bundler can't handle multiple exports per module (@barneycarroll)
The
domFor
patch breaks the compiled output: the bundler can't handle multiple exports per module. 1.Bump shell-quote from 1.7.2 to 1.7.3 (@dependabot[bot])
Bumps shell-quote from 1.7.2 to 1.7.3. Changelog. Sourced from shell-quote's changelog. 1.7.3.
Bump minimist from 1.2.5 to 1.2.6 (@dependabot[bot])
Bumps minimist from 1.2.5 to 1.2.6. Commits. 7efb22a 1.2.6.
Add back CI (@pygy)
Enable CI that was I suppose disabled by mistake.
Add missing prerelease branch target. (@JAForbes)
Addresses this issue JAForbes/pr-release#345 (raised by @pygy).
Kick jsonp - fixes #2682 (@StephanHoyer)
Kick JSONP. I removed all stuff related to jsonp. It's only rarely used nowadays, If anyone needs it, there are plenty of alternative packages.