Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - v3.0.0 #2776

Merged
merged 22 commits into from
Jan 24, 2023
Merged

Release - v3.0.0 #2776

merged 22 commits into from
Jan 24, 2023

Conversation

JAForbes
Copy link
Collaborator

@JAForbes JAForbes commented May 30, 2022

Release v3.0.0

Changelog

Major Changes

Actually remove ospec from the main code base (@pygy)

It is still used as a dev-dependency.

Kick promise polyfill (@StephanHoyer)

allow trailing slash for routes - fixes #2763 (@StephanHoyer)

Minor Changes

Bump terser from 4.3.4 to 4.8.1 (@dependabot[bot])

Bumps terser from 4.3.4 to 4.8.1. Changelog. Sourced from terser's changelog. v4.8.1 (backport).

implement m.domFor() and use it internally to move and remove nodes. Fix #2780 (@pygy)

Add m.domFor(vnode). This adds m.domFor(vnode) as described in #2780 (with a twist to deal with node removal between iterations).

Patch Changes

Bypass css text (@pygy)

Shave a few bytes by setting element.style directly, rather than element.style.cssText, since the former is now supported everywhere relevant.

Fix silent build error in next: bundler can't handle multiple exports per module (@barneycarroll)

The domFor patch breaks the compiled output: the bundler can't handle multiple exports per module. 1.

Bump shell-quote from 1.7.2 to 1.7.3 (@dependabot[bot])

Bumps shell-quote from 1.7.2 to 1.7.3. Changelog. Sourced from shell-quote's changelog. 1.7.3.

Bump minimist from 1.2.5 to 1.2.6 (@dependabot[bot])

Bumps minimist from 1.2.5 to 1.2.6. Commits. 7efb22a 1.2.6.

Add back CI (@pygy)

Enable CI that was I suppose disabled by mistake.

Add missing prerelease branch target. (@JAForbes)

Addresses this issue JAForbes/pr-release#345 (raised by @pygy).

Kick jsonp - fixes #2682 (@StephanHoyer)

Kick JSONP. I removed all stuff related to jsonp. It's only rarely used nowadays, If anyone needs it, there are plenty of alternative packages.

@JAForbes JAForbes added major Type: Breaking Change For any feature request or suggestion that could reasonably break existing code Type: Bug For bugs and any other unexpected breakage Type: Release Blocker This should be fixed before the next release labels May 30, 2022
@github-actions
Copy link

⚠⚠⚠ Hey @JAForbes, did you mean to open this against next? ⚠⚠⚠

StephanHoyer and others added 2 commits May 30, 2022 08:38
This hasn't been true since v2.0
StephanHoyer and others added 11 commits June 6, 2022 12:56
Without specifying target:master the prerelease version calculation would be incorrect.
* Add back CI, remove ospec as a run-time dependency

* Fix the lint:docs errors

* Add back ospec for now, with a compatible version
* Actually remove ospec from the main code base (it is still used as a dev-dependency)

* fix a copy error

Co-authored-by: Barney Carroll <[email protected]>

Co-authored-by: Barney Carroll <[email protected]>
@JAForbes JAForbes added minor Type: Enhancement For any feature request or suggestion that isn't a bug fix labels Jun 21, 2022
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@pygy
Copy link
Member

pygy commented Jun 21, 2022

@JAForbes the pr action failed here, not sure what happens or if I can re-run it safely...

@JAForbes JAForbes added the dependencies Pull requests that update a dependency file label Jun 21, 2022
@JAForbes
Copy link
Collaborator Author

@JAForbes the pr action failed here, not sure what happens or if I can re-run it safely...

Re-ran it and passed. I've seen it before and raised it with github support. Sometimes the PATCH endpoint returns a 404 erroneously.

To answer your question its safe to re-run the pr job.

@pygy
Copy link
Member

pygy commented Jun 21, 2022

Great, thanks !

Bumps [shell-quote](https://github.com/substack/node-shell-quote) from 1.7.2 to 1.7.3.
- [Release notes](https://github.com/substack/node-shell-quote/releases)
- [Changelog](https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md)
- [Commits](https://github.com/substack/node-shell-quote/compare/v1.7.2...1.7.3)

---
updated-dependencies:
- dependency-name: shell-quote
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@JAForbes JAForbes added the patch label Jun 23, 2022
dead-claudia and others added 6 commits June 22, 2022 23:07
Bumps [terser](https://github.com/terser/terser) from 4.3.4 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
* [DOM mocks] enable setting element.style

* Use the style setter directly
@JAForbes JAForbes merged commit 274cb2f into master Jan 24, 2023
@pygy
Copy link
Member

pygy commented Jan 26, 2023

@JAForbes I messed up with the v2.x branch and accidentally triggered pr-release to run from there, i.e. the wrong branch.

It would be nice if there were branch checks before doing irreversible operations (and possibly other idiot proofing measures).

Also, from here, how do we fix things up?

@Prid13
Copy link

Prid13 commented Jan 28, 2023

Was the wrong version released as 2.2.3? :O

@pygy
Copy link
Member

pygy commented Jan 28, 2023

Yes, I messed up while setting up the v2.x branch and triggered the release script by accident (from a Github action that I hadn't read to the bottom).

It was up for about one hour and a half, I hope it didn't derail your workflow...

@Prid13
Copy link

Prid13 commented Jan 28, 2023

No, not at all, was just testing Mithril when I noticed some changes that I had to investigate 😅

Oh, it's fixed already? Sadly the Mithril CDN link I found on Google as the top result still holds that wrong version: https://cdnjs.com/libraries/mithril :/

@pygy
Copy link
Member

pygy commented Jan 28, 2023

Oh, thanks for the heads up. Not sure I can solve this on their hand, short of pushing yet another release...

cdnjs/packages#1450 ... We'll see how things go over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file major minor patch Type: Breaking Change For any feature request or suggestion that could reasonably break existing code Type: Bug For bugs and any other unexpected breakage Type: Enhancement For any feature request or suggestion that isn't a bug fix Type: Release Blocker This should be fixed before the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants