replace rossrad.dat with rossrad.nc (#1083)

[RussTreadon-NOAA]

Description

Three files reference rossrad.dat whereas test/Data contains rossrad.nc. This PR replaces the three occurrences of rossrad.dat with rossrad.nc.

Issue(s) addressed

• fixes Replace rossrad.dat with rossrad.nc #1083

Testing

to be done

Dependencies

none

[RussTreadon-NOAA]

Document problem with develop at 204a3eee

Install develop at 204a3eee on Hercules. Load GDASApp modulefiles/GDAS/hercules.intel.lua to build soca. Build is successful. Next execute make install. Install failed with the following error

-- Installing: /work/noaa/da/rtreadon/git/soca/soca_install/share/soca/testdata/72x35x25/INPUT/ocean_hgrid.nc
-- Installing: /work/noaa/da/rtreadon/git/soca/soca_install/share/soca/testdata/72x35x25/INPUT/ocean_topog.nc
CMake Error at soca/test/cmake_install.cmake:65 (file):
  file INSTALL cannot find
  "/work/noaa/da/rtreadon/git/soca/recursive/bundle/soca/test/Data/rossrad.dat":
  No such file or directory.
Call Stack (most recent call first):
  soca/cmake_install.cmake:84 (include)
  cmake_install.cmake:65 (include)


make: *** [Makefile:130: install] Error 1

install is looking for rossrad.dat. The file is now rossrad.nc.

[RussTreadon-NOAA]

Document fix with bugfix/rossrad at 9d9d318

Install bugfix/rossrad 9d9d318 on Hercules. Load GDASApp modulefiles/GDAS/hercules.intel.lua to build soca. Build is successful. Next execute make install. The install successfully ran to completion. In partcular, file rossrad.nc is installed

- Installing: /work/noaa/da/rtreadon/git/soca/rossrad_install/share/soca/testdata/72x35x25/INPUT/ocean_hgrid.nc
-- Installing: /work/noaa/da/rtreadon/git/soca/rossrad_install/share/soca/testdata/72x35x25/INPUT/ocean_topog.nc
-- Installing: /work/noaa/da/rtreadon/git/soca/rossrad_install/share/soca/testdata/rossrad.nc
-- Installing: /work/noaa/da/rtreadon/git/soca/rossrad_install/share/soca/testdata/godas_sst_bgerr.nc

[guillaumevernieres]

Thanks @RussTreadon-NOAA

[RussTreadon-NOAA]

test_soca_linearization_error failure

Run ctests from builds of develop at 204a3ee and bugfix/rossrad at 9d9d318 on Hercules. All tests pass except one

98% tests passed, 1 tests failed out of 65

Label Time Summary:
executable    =  22.83 sec*proc (15 tests)
mpi           = 218.94 sec*proc (60 tests)
script        = 228.28 sec*proc (50 tests)
soca          = 251.11 sec*proc (65 tests)

Total Test time (real) = 312.55 sec

The following tests FAILED:
        1483 - test_soca_linearization_error (Failed)

Rerun test_soca_linearization_error with -VV. Failure is due to reference check

OOPS_STATS Run end                                  - Runtime:      2.68 sec,  Memory: total:     1.29 Gb, per task: min =   631.65 Mb, m\
ax =   659.20 Mb
Run: Finishing oops::LinearizationError<SOCA> with status = 0
terminate called after throwing an instance of 'oops::TestReferenceFloatMismatchError'
  what():  Test reference Float mismatch @ Line:22
Test Val : -1.0127140382682740e+00
Ref  Val : -1.0129154677576744e+00
Delta    : 2.0142948940038430e-04
Relative tolerance: 1.0128147530129743e-06
Absolute tolerance: 1.0000000000000000e-04
Test Line: '   tocn   min=-1.0127140382682740   max=2.5014114191149748   mean=-0.0000945299136020'
Ref Line : '   tocn   min=-1.0129154677576744   max=2.5014114191278107   mean=-0.0000944030347193'

I build the develop and bugfix/rossrad soca bundle using modules from GDASApp modulefiles/GDAS/hercurles.intel.lua. This is a spack-stack/1.6.0 modulefile.

I am not sure what compilers and modules were used to generate the reference file. Perhaps my builds use different compilers and/or modules. Given this, I will not commit linearization_error.test generated by my run of linearization_error.test

[RussTreadon-NOAA]

The changes in this PR are required for GDASApp branch feature/install to successfully complete the install (see comment here). For additional details see GDASApp issue #1302.

[travissluka]

Thanks, I made one small change of removing rossrad.nc from .gitattributes. That line is not needed since it is covered by the above *.nc case.

[RussTreadon-NOAA]

Thanks, I made one small change of removing rossrad.nc from .gitattributes. That line is not needed since it is covered by the above *.nc case.

Thank you @travissluka for making this correction.

[RussTreadon-NOAA]

Thank you @travissluka