-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Existence of SplitPane-Handle isn't clear to the user #179
Comments
Very useful. Anyone looking for SwingGuiUtils.scaleToDpi(int) function you can use DPIController class in this repo. |
Yeah, I basically just copied the code over here. I think I didn't even need to do that. I was just wondering whether it would be okay to add these dots as a PR ^^ |
I hope the devs will consider. ;-) |
Sorry for the late reply... Yes, these dots would be nice and I'll accept a PR 👍 But then we do not need two extra classes. Just remembered that there is already some code in FlatLaf that paints dots. It is in the toolbar: The code is in FlatLaf/flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatToolBarBorder.java Lines 66 to 96 in f0fd02e
You could use method Maybe also increase divider thickness, which is currently 5px and probably to small for 3px dots.
Regarding color of dots:
To be consistent I would suggest something like:
|
Hi @DevCharly thank you for above, any chance this will be added soon to release. |
I didn't get to do this yet, sorry. It's rather low prio right now, as this basically already works for us 😓 |
Hi @Bios-Marcel thanks for the update, I tried your solution but then I got a bug on second monitor on Mac, the icons disappear. |
Oh, that's interesting. When dragging the window over? |
When the window(s) are launched on the second monitor. |
I'm working on it... |
@DevCharly Stupid question on the side: Do yout take donations anywhere? |
@Bios-Marcel I've been asking the same not at all stupid question in the past. No answer from @DevCharly so far, but I am still interested! Being an Open Source author myself, I really would like to express my gratitude for the time and passion that goes into this. |
@Bios-Marcel thanks for the offer. @j-dimension found and answered you Email. Thx. |
The splitpane divider grip is implemented in commit 18d8c7d. @Bios-Marcel the divider width is still 5px, but the dots are smaller than in your code. FlatLaf/flatlaf-core/src/main/resources/com/formdev/flatlaf/FlatLaf.properties Lines 535 to 540 in 18d8c7d
Following code makes divider wider, dots larger and use 4 dots: UIManager.put( "SplitPane.dividerSize", 9 );
UIManager.put( "SplitPaneDivider.gripDotCount", 4 );
UIManager.put( "SplitPaneDivider.gripDotSize", 4 );
UIManager.put( "SplitPaneDivider.gripGap", 3 ); To disable divider grip use: UIManager.put( "SplitPaneDivider.style", "plain" ); |
Unless a user knows that a splitpane is present, it's not possible to see it, as there's currently no handle.
I'd suggest adding a handle. We currently add three dots that use the same colors as the disabled font color.
We'd like to properly implement this though. We've been using this hack for a while and would like to contribute this.
Would you be okay with that? If so, what color should we use for it and what should the size of the handle and the icons be?
This is the code we've been using and an image of what it looks like:
Icon:
Border:
To use it:
The text was updated successfully, but these errors were encountered: