Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give unique names to some of the default themes listed in FlatAllIJThemes #201

Closed
grimlock81 opened this issue Nov 3, 2020 · 3 comments
Closed

Give unique names to some of the default themes listed in FlatAllIJThemes #201

grimlock81 opened this issue Nov 3, 2020 · 3 comments
Milestone
0.44

Comments

@grimlock81
Copy link

grimlock81 commented Nov 3, 2020 •
edited
Loading

Some of the themes listed in FlatAllIJThemes.INFOS have the same name for different Java classes:

  • Arc Dark
  • Dracula
  • Solarized Dark
  • Solarized Light

Can we give these ones unique names? This is because in my application I list all the available themes allowing the user to select the theme. Currently with those 4 names, the user cannot distinguish between the two variants. Thanks.
@DevCharly
Copy link
Collaborator

Hmm, maybe I should change all names of the material UI lite collection to differ them from non material themes.
Something like "Arc Dark (Material)"

@grimlock81
Copy link
Author

Yes that would be great.

DevCharly added a commit that referenced this issue Nov 10, 2020
@DevCharly
IntelliJ Themes: added suffix "(Material)" to names of all Material U…
fd0c2a5 
…I Lite themes to avoid duplicate theme names (issue #201)
DevCharly added a commit that referenced this issue Nov 10, 2020
@DevCharly
IntelliJ Themes: added getName() method to all InttelliJ Laf classes …
605c77e 
…so that they return same name as defined in class FlatAllIJThemes (issue #201)
@DevCharly
Copy link
Collaborator

Fixed in latest snapshot

@DevCharly DevCharly added this to the 0.44 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.44
Development

No branches or pull requests
2 participants
@DevCharly @grimlock81