Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Consider adding themes.json to main jar #221

Closed
grimlock81 opened this issue Nov 30, 2020 · 1 comment
Closed

Request: Consider adding themes.json to main jar #221

grimlock81 opened this issue Nov 30, 2020 · 1 comment
Milestone

Comments

@grimlock81
Copy link

This is a request. The flatlaf-demo.jar file contains a themes.json file under com\formdev\flatlaf\demo\intellijthemes

This file contains the list of all available FlatLAF themes (I assume it's all of them) as well as useful metadata about each theme including whether it's a dark theme or not. It would be useful to have this information available in the main flatlaf.jar file as I would like to offer the user the choice of which theme to use, and I would like to group the themes into Light Theme and Dark Theme groups.

Currently I get the list of available FlatLAF themes from the com.formdev.flatlaf.intellijthemes.FlatAllIJThemes.INFOS which only offers the name of the theme and not whether it's a dark theme or not.

Alternatively, is there a way of finding out whether a theme is dark or not without having to instantiate an instance of the ThemeLaf implementation. Thanks.

@DevCharly
Copy link
Collaborator

Don't want to ship themes.json because this may change in the future...

So I have added the dark flag to FlatAllIJThemes.INFOS in recent commit.

@DevCharly DevCharly added this to the 0.46 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants