Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about combobox style #227

Closed
martinm1000 opened this issue Dec 16, 2020 · 10 comments
Closed

Question about combobox style #227

martinm1000 opened this issue Dec 16, 2020 · 10 comments
Milestone

Comments

@martinm1000
Copy link

Hi !

I can't find the UI default that makes non-editable combobox selected item in bold.
How can I control this ? I would like the selected non-editable item not to be bolder.

image

I have jcombobox items with html+bold, and the selected entry seems to have its non-bold text more bold that it should.

Old screenshot before using FlatLAF:
image

Now:
image

@DevCharly
Copy link
Collaborator

I can't find the UI default that makes non-editable combobox selected item in bold.

Hmm, I'm not aware of such an option. The text should be not bold.

image

Also can not reproduce the "bolder" HTML text:

image

Can you give me some details about your machine? Windows? Java version?

Looks like a problem with the combobox font.
The first screen shot is from the FlatLaf demo, right?
In the demo press Ctrl+Shift+Alt+X, which enables the FlatLaf UI Inspector.
Then move the mouse over the combobox and check whether the font in the tooltip is equal to other component types:

image

@martinm1000
Copy link
Author

I'm currently connecting through RDP, I might need to adjust the quality settings here. But since I see correctly the difference with the combo choices...

This is on Windows 10, Java 15.0.1.
And yes, the 1st screenshot is your demo for the 0.45

image

@martinm1000
Copy link
Author

Oh wow, I'm sorry. It seems to be an artifact of my RDP connection at work (damn covid). With better quality settings, I don't see a difference anymore. I just don't understand why I was seeing bold only on non editable comboboxes... !

now:

image

It seems windows render differently under RDP, as I can still see the 'bold' in my earlier screenshot. Right ?

@martinm1000
Copy link
Author

I've dialed down my quality settings and I don't think I'm crazy:

The top one is ok and was my earlier run of the demo with high quality RDP settings.
I've superimposed another run of the demo (executed after changing to less quality).
The top one still looks ok, but the newly ran java seems to be affected.

image

I guess we could close this issue, as it is not a real problem under normal circumstances.

@DevCharly
Copy link
Collaborator

It seems when using lower quality RDP, that anti-aliasing is disabled, except for non-editable comboboxes, which seem to use gray-scale anti-aliasing (from your first screenshot at 400%):

image

For higher quality RDP, default LCD anti-aliasing is used (from your first screenshot at 600%):

image

So the remaining question is why do FlatLaf non-editable comboboxes use gray-scale anti-aliasing for lower quality RDP?

@martinm1000
Copy link
Author

Maybe its not even FlatLaf related ? it's a bizarre one !

@martinm1000
Copy link
Author

martinm1000 commented Dec 16, 2020

Its not just the combo boxes:

image

The multi-line tooltip seems to have the issue.

But this one is bizarre:
image

edit: ok, not that bizarre; we have to accept bad looking fonts on not high quality - but some components seems to have their antialiasing still applied which make then look bold.

@DevCharly
Copy link
Collaborator

Can now reproduce the problem on my Windows desktop when disabling AA via command line option -Dawt.useSystemAAFontSettings=off. Other Lafs like Windows, Nimbus, ... do not have this issue.

DevCharly added a commit that referenced this issue Dec 18, 2020
…ased text in some components if text antialiasing is disabled in system (issue #227)
@DevCharly
Copy link
Collaborator

Fixed in master branch. Thanks for reporting.

@DevCharly DevCharly added this to the 0.46 milestone Dec 18, 2020
@martinm1000
Copy link
Author

Oh nice ! thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants