MenuItem iconTextGap appears to be affecting margins

[smileatom]

Hi,

iconTextGap is supposed to govern the space between the icon<->text in a label component.
In JMenuItem this appears to be making the entire menu much larger when set.

Here is an example of iconTextGap 4: (Notice that the menu appears to be in general too wide)

The same menu with iconTextGap of 10:

With an increase in iconTextGap the menu gets wider and wider for no reason. Its also likely too wide at smaller values due to this issue (this is on MacOS).

On my non-retina display increasing iconTextGap from 4 to 10 increased the menu width by 17 pixels.

[DevCharly]

Looks like that iconTextGap is also used for the gap left to the icon, for the gap between text and accelerator, and gap right to accelerarator.

Here is popup menu with two equal menu items, but the second has a large iconTextGap:

Same happens in Metal Laf. On Nimbus and Windows Laf it is similar.

FlatLaf currently uses the default menu item layout that is implemented in sun.swing.MenuItemLayoutHelper, which uses iconTextGap for all gaps.

I plan to change this for issue #3. Then I can also fix this issue.

[smileatom]

Interesting, I guess I assumed it was just the JLabel property for the menu item. Maybe since theres accelerator and hotkeys that can be displayed in the margins it was overloaded

[DevCharly]

fixed in master branch