-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FlatComboPopup accessible and do not ignore prototype display value #80
Comments
Hmm.. This is exactly what we need! But, for some reason, I thought FlatLaf didn't implement it. |
Also, this is not related to the issue here, but in FlatLaf/flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatComboBoxUI.java Lines 484 to 489 in 97d5792
The problem for us is that we use prototype to speed up these calculations. Unfortunately, here it is set to Is there any specific reason why prototype display value is set to |
I think the idea was to use the prototype to calculate the width of the combobox itself and then ignore it when computing popup width to get wider popup. But this contrary to what the prototype is mainly there: increase performance. I think I should change this... |
I agree, |
Now changed in master branch. |
fixed in 0.29 |
There are cases when
FlatComboBoxUI
andFlatComboPopup
need to be customized (i.e. to fix this problem: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4618607)Currently
FlatComboPopup
is private and cannot be overriden by any class that inherits fromFlatComobBoxUI
. This leads to unnecessary copy/paste.The text was updated successfully, but these errors were encountered: