Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the text of the GPLv3 at the bottom of the LICENSE.md file #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DilumAluthge
Copy link

If you're interested in registering your Julia packages in the Julia General registry, you might notice that the AutoMerge CI check has trouble parsing the license file.

The easiest way to fix AutoMerge is to include the text of the GPLv3 license at the bottom of the LICENSE.md file. Then AutoMerge will detect the GPL license text, and the check will pass.

@ViralBShah
Copy link

@JKRT It was great to see you at the Modelica Conference. We were trying to figure out why we couldn't have these packages in the Julia General registry, and figured out it had to do with the Automerge system interpreting the license file correctly as an OSI approved open source license.

This PR would make it possible to register packages with the Modelica license in the Julia registry.

cc @ChrisRackauckas

@JKRT
Copy link
Owner

JKRT commented Nov 11, 2022

@JKRT It was great to see you at the Modelica Conference. We were trying to figure out why we couldn't have these packages in the Julia General registry, and figured out it had to do with the Automerge system interpreting the license file correctly as an OSI approved open source license.

This PR would make it possible to register packages with the Modelica license in the Julia registry.

cc @ChrisRackauckas

Hey great to hear from you @ViralBShah ! Sorry for a late reply I have been busy with several things...

I will accept this PR. However, I have to fix some issues that occured in Julia 1.8 to proceed.

Hopefully I will have some time to do it soon. However, the OpenModelica team have some other packages such as OMJulia.jl https://github.com/OpenModelica/OMJulia.jl that we would like to register

@bilderbuchi
Copy link

What about the BSD-new license mentioned at the top of the license file? Does that one's text also have to be added?

@DilumAluthge
Copy link
Author

However, the OpenModelica team have some other packages such as OMJulia.jl https://github.com/OpenModelica/OMJulia.jl that we would like to register

I've made a similar PR for OMJulia.jl here: OpenModelica/OMJulia.jl#70

I'm happy to make additional PRs for other packages - just let me know which packages.

@DilumAluthge
Copy link
Author

What about the BSD-new license mentioned at the top of the license file? Does that one's text also have to be added?

For the purposes of registering (in the Julia General registry), it's sufficient to just include the text of the GPLv3.

@JKRT
Copy link
Owner

JKRT commented Feb 23, 2023

@DilumAluthge

I have yet to merge this since this package is still alpha. However, I am currently working on a private branch where I have gotten some of the components of the MSL to simulate.

However, getting certain parts of the algorithmic subset of Modelica running takes time.
The current plan is to finish this work sometime during the spring, and once some significant models, such as the V6 model, are running, I will go ahead and register the packages.

The ETA is probably in about one-three months or so

@DilumAluthge
Copy link
Author

Bump @JKRT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants