Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --binary when creating patch for unstaged files #603

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GrahamBorland
Copy link

@GrahamBorland GrahamBorland commented Sep 6, 2022

This fixes the pre-commit hook to cope with unstaged binary files. Without this option, the hook fails when there is an unstaged binary file.

error: cannot apply binary patch to 'some/binary/file' without full index line
error: some/binary/file: patch does not apply

@GrahamBorland GrahamBorland marked this pull request as ready for review September 6, 2022 10:21
@GrahamBorland GrahamBorland changed the title Add --binary when creating patch for unstaged files Add --binary when creating patch for unstaged files Sep 6, 2022
@JLLeitschuh
Copy link
Owner

Sorry it's taken so long to get back to you on this. I'm happy to merge this, but I need an entry in the changelog file. After that, more than happy to merge this!

@GrahamBorland
Copy link
Author

Changelog entry added, thanks!

@JLLeitschuh
Copy link
Owner

Looks like CI is failing for this PR. Can you take a look?

@JLLeitschuh
Copy link
Owner

Once CI is passing, I'm more than happy to merge this 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants