support ktlint 0.45-0.48 #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakingrufus
force-pushed
the
ktlint-upgrades
branch
from
ada323a
to
8e78243
Compare
wakingrufus
commented
Jan 12, 2023
| @@ -100,8 +100,8 @@ class TestProject( | |||
| } | |||
|
|
|||
| companion object { | |||
| const val CLEAN_SOURCES_FILE = "src/main/kotlin/clean-source.kt" | |||
There was a problem hiding this comment.
this now fails lint as an "unfixable" error so we need to change these
wakingrufus
force-pushed
the
ktlint-upgrades
branch
from
8e78243
to
a178f3b
Compare
wakingrufus
commented
Jan 12, 2023
| } | ||
| } catch (e: ParseException) { |
There was a problem hiding this comment.
ParseException was changed to KtLintParseException, so this will catch either one
wakingrufus
force-pushed
the
ktlint-upgrades
branch
from
a178f3b
to
777b6cd
Compare
|
Thank you 🚀 , would be awesome it this would get merged and work. |
wakingrufus
force-pushed
the
ktlint-upgrades
branch
2 times, most recently
from
9d043cb
to
01c2d3d
Compare
wakingrufus
force-pushed
the
ktlint-upgrades
branch
5 times, most recently
from
0bac117
to
9b7bd21
Compare
JLLeitschuh
reviewed
Jan 24, 2023
plugin/src/main/kotlin/org/jlleitschuh/gradle/ktlint/worker/KtLintInvocation.kt
Outdated
Show resolved
Hide resolved
JLLeitschuh
reviewed
Jan 24, 2023
plugin/src/main/kotlin/org/jlleitschuh/gradle/ktlint/worker/KtLintInvocation.kt
Outdated
Show resolved
Hide resolved
JLLeitschuh
reviewed
Jan 24, 2023
plugin/src/main/kotlin/org/jlleitschuh/gradle/ktlint/worker/KtLintInvocation.kt
Outdated
Show resolved
Hide resolved
JLLeitschuh
reviewed
Jan 24, 2023
plugin/src/main/kotlin/org/jlleitschuh/gradle/ktlint/worker/KtLintInvocation.kt
Outdated
Show resolved
Hide resolved
JLLeitschuh
requested changes
Jan 24, 2023
wakingrufus
force-pushed
the
ktlint-upgrades
branch
from
b1eab6e
to
6e353b7
Compare
wakingrufus
force-pushed
the
ktlint-upgrades
branch
from
6e353b7
to
2689b69
Compare
JLLeitschuh
reviewed
Jan 25, 2023
| cb: (LintError, Boolean) -> Unit | ||
| ): com.pinterest.ktlint.core.KtLint.ExperimentalParams { | ||
| val script = !file.name.endsWith(".kt", ignoreCase = true) | ||
| val editorConfigOverride = userDataToEditorConfigOverride(userData) |
There was a problem hiding this comment.
Store this in a local lazy variable. It doesn't need to be created for every file
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
wakingrufus
force-pushed
the
ktlint-upgrades
branch
from
2689b69
to
7a76c8b
Compare
This was referenced Jan 27, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support ktlint 0.46-0.48
add tests for 0.44 and 0.45 as well
This resolves #589
This resolves #607